Skip to content

Conversation

@UrbanHelix
Copy link
Contributor

Fixes issue (#111038) by skipping updating window style and calling ShowWindow when toggling borderless while fullscreen.

Tested on windows 11 using the MRP (fullscreen-bug.zip).
Issue appeared after pressing "Toggle Fullscreen" twice.

Before fix:
image

After fix:
image

@UrbanHelix UrbanHelix requested a review from a team as a code owner November 1, 2025 22:16
@bruvzg bruvzg self-requested a review November 1, 2025 22:18
@bruvzg bruvzg added this to the 4.6 milestone Nov 1, 2025
@AThousandShips AThousandShips changed the title [windows] Fixed legacy border when toggling borderless while fullscreen [Windows] Fix legacy border when toggling borderless while fullscreen Nov 2, 2025
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BORDERLESS + FULLSCREEN is a meaningless combination so it makes sense to not apply the flag when in full-screen.

@Repiteo Repiteo merged commit 38eefba into godotengine:master Nov 4, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 4, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants